SUP-2881, Show placements on challenge cards only for "Contest Submis… #620
Conversation
…sion" type submissions -- Added filter for submission type being 'Contest Submission' for calculating highest placement for the design challenges -- Fixed use of calculation of highest placement, it was using _.max while we should use _.min instead. -- Fixed style in case we are not showing placement for past challenges
| @@ -59,7 +59,9 @@ | |||
| $scope.imageURL = $scope.challenge.userDetails.submissions[0].submissionImage && $scope.challenge.userDetails.submissions[0].submissionImage.full; | |||
| $scope.selectedImage = $scope.imageURL; | |||
|
|
|||
| $scope.challenge.highestPlacement = _.max($scope.challenge.userDetails.submissions, 'placement').placement; | |||
There was a problem hiding this comment.
@tladendo @parthshah @nlitwin Do you guys see use of _.min instead of _.max, inappropriate?
There was a problem hiding this comment.
Is placement ordered 1 highest, 2 second, i.e. the higher the number, the lower rank you are? If so, then _.min seems appropriate. :)
There was a problem hiding this comment.
yes, it should be like that. We already have that for other tracks, but somehow design subtrack is still using _.max.
There was a problem hiding this comment.
I am confused , shouldn't we be using _.min? 1 being the best placement / rank.
@vikasrohit can we merge this and have this qa'd once we have answered the above question?
There was a problem hiding this comment.
Yes, we should and that is why I have changed it to _.min. However, I just want to make sure that I didn't miss anything which was trivial and I was not able to see that and further, why this is never caught when we are doing exactly opposite to what is required. :)
|
Merging PR to get it QA'ed. |
…ment-for-content-submissions-only SUP-2881, Show placements on challenge cards only for "Contest Submis…
vikasrohit
deleted the
feature/sup-2881-show-placement-for-content-submissions-only
branch
@parthshah @nlitwin @tladendo Please review the changes. @tladendo it would be great, as you have recently worked on design challenges issues, if you can take a look at changes, specifically for changing the style and use of _.min instead of _.max function.
-- Added filter for submission type being 'Contest Submission' for calculating highest placement for the design challenges
-- Fixed use of calculation of highest placement, it was using _.max while we should use _.min instead.
-- Fixed style in case we are not showing placement for past challenges